Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostcardAssetLoader as OutputLoader to PostcardAssetSaver #34

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Seldom-SE
Copy link
Contributor

This makes it so that the .meta files generated by PostcardAssetSaver use PostcardAssetLoader as a loader, which allows the asset to load with asset preprocessing

Breaking changes

The type parameter of PostcardAssetSaver must implement Deserialize. This is only a breaking change if a release is made before this pr is merged, since PostcardAssetSaver was private in the last release (0.10.0 at the time of writing).

Copy link
Owner

@NiklasEi NiklasEi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thank you.

@NiklasEi NiklasEi merged commit ef3d881 into NiklasEi:main Apr 6, 2024
4 checks passed
@NiklasEi
Copy link
Owner

NiklasEi commented Apr 6, 2024

Are you using this in a project? That would conclude at least the "test" part of #22 then. I haven't used asset preprocessing/meta files before.

@Seldom-SE Seldom-SE deleted the postcard_saver_loader branch April 7, 2024 02:21
@Seldom-SE
Copy link
Contributor Author

Are you using this in a project?

Yeah, but it's a side project, and I'm not likely to finish it. I have an easily-editable file with items with string IDs, then I preprocess the file, replacing the string IDs with numerical ones. That gets saved as a binary file, which is loaded by the actual game

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants