Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/6 restructure module structure #9

Merged
merged 47 commits into from
May 24, 2024

Conversation

dannymeijer
Copy link
Member

@dannymeijer dannymeijer commented May 24, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

mikita-sakalouski and others added 30 commits May 22, 2024 17:32
…nal.github.com:Nike-Inc/koheesio into feat/5-switch-testing-to-native-hatch-command
- readers module is now at koheesio.spark.readers instead of koheesio.steps.readers
- transformations is now at koheesio.spark.transformations instead of koheesio.steps.transformations
- rank_dedup.py has been removed (fully replaced by row_number_dedup.py now)
- writers is now at koheesio.spark.writers instead of koheesio.steps.writers
- spark_utils.py is now moved to koheesio.spark.utils; on_databricks has been moved to spark.utils
- EtlTask is now part of koheesio.spark module; tasks module has been removed
dannymeijer and others added 10 commits May 24, 2024 11:50
- readers module is now at koheesio.spark.readers instead of koheesio.steps.readers
- transformations is now at koheesio.spark.transformations instead of koheesio.steps.transformations
- rank_dedup.py has been removed (fully replaced by row_number_dedup.py now)
- writers is now at koheesio.spark.writers instead of koheesio.steps.writers
- spark_utils.py is now moved to koheesio.spark.utils; on_databricks has been moved to spark.utils
- EtlTask is now part of koheesio.spark module; tasks module has been removed
….com:Nike-Inc/koheesio into feat/6-restructure-module-structure
@dannymeijer dannymeijer linked an issue May 24, 2024 that may be closed by this pull request
@dannymeijer dannymeijer force-pushed the feat/6-restructure-module-structure branch from a3ea483 to 54c2548 Compare May 24, 2024 15:05
@mikita-sakalouski mikita-sakalouski self-requested a review May 24, 2024 15:30
Copy link
Contributor

@mikita-sakalouski mikita-sakalouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/data/snowflake_staging.parq/._SUCCESS.crc Outdated Show resolved Hide resolved
tests/data/snowflake_staging.parq/_SUCCESS Outdated Show resolved Hide resolved
Copy link
Contributor

@mikita-sakalouski mikita-sakalouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@dannymeijer dannymeijer merged commit 89af932 into main May 24, 2024
4 checks passed
@dannymeijer dannymeijer deleted the feat/6-restructure-module-structure branch May 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Restructure module structure
2 participants