-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/6 restructure module structure #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-native-hatch-command
…nal.github.com:Nike-Inc/koheesio into feat/5-switch-testing-to-native-hatch-command
- readers module is now at koheesio.spark.readers instead of koheesio.steps.readers - transformations is now at koheesio.spark.transformations instead of koheesio.steps.transformations - rank_dedup.py has been removed (fully replaced by row_number_dedup.py now) - writers is now at koheesio.spark.writers instead of koheesio.steps.writers - spark_utils.py is now moved to koheesio.spark.utils; on_databricks has been moved to spark.utils - EtlTask is now part of koheesio.spark module; tasks module has been removed
- readers module is now at koheesio.spark.readers instead of koheesio.steps.readers - transformations is now at koheesio.spark.transformations instead of koheesio.steps.transformations - rank_dedup.py has been removed (fully replaced by row_number_dedup.py now) - writers is now at koheesio.spark.writers instead of koheesio.steps.writers - spark_utils.py is now moved to koheesio.spark.utils; on_databricks has been moved to spark.utils - EtlTask is now part of koheesio.spark module; tasks module has been removed
….com:Nike-Inc/koheesio into feat/6-restructure-module-structure
dannymeijer
force-pushed
the
feat/6-restructure-module-structure
branch
from
May 24, 2024 15:05
a3ea483
to
54c2548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
…ure' into feat/6-restructure-module-structure # Conflicts: # pyproject.toml
mikita-sakalouski
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: