Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Exists function in DeltaTableStep should not log error #70

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

femilian-6582
Copy link

@femilian-6582 femilian-6582 commented Sep 27, 2024

… run black

Description

The exists function of the DeltaTableStep should notify the user about the non existence of the table with a different log level depending on the value of the create_if_not_exists boolean flag (whereas now it is logging always with level error).
If the flag is True than the log level is set to info. If the flag is False than the log level is set to error.

A possible alternative is to set the log level always to info or warning but this solution proposed already by the reporter looks more informative.

Related Issue

#34

Motivation and Context

Improving logging by making more informative and adeguate to the use case.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant