Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] - Snowflake reader and writer have different parameter names for table name #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riccamini
Copy link
Contributor

Description

SnowflakeReader and SnowflakeWriter have different parameter names for the table name

Related Issue

#65

Motivation and Context

It would improve usability using the same parameter for the table name in both SnowflakeReader and SnowflakeWriter

How Has This Been Tested?

We have added tests to cover the table parameter being passed as "table" instead of "dbtable"

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@riccamini riccamini requested a review from a team as a code owner September 27, 2024 10:16
@riccamini
Copy link
Contributor Author

Maybe it's worth reviewing the available classes in the package for an upcoming major release. We can see that a user can also use DbTableQuery to read an entire table, and this already provides the alias table for the dbtable parameter. The original idea could have been to use DbTableQuery to read an entire table, and Query to execute a query. If that's the case, we could make that more explicit in the class doc to not use SnowflakeReader directly.

Copy link

@pariksheet pariksheet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... cheers

Copy link
Member

@dannymeijer dannymeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants