Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add streaming option to FileLoader. #51

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add streaming option to FileLoader. #51

merged 1 commit into from
Jun 17, 2024

Conversation

BrendBraeckmans
Copy link
Contributor

Description

Add streaming option to FileLoader. Default behaviour is batch.

Related Issue

Issue 50

Motivation and Context

Having a streaming option for the FileLoader would be beneficial during UT's or for people that are not on Databricks and can't make use of the Databricks proprietary Autoloader.

How Has This Been Tested?

  • UT's
  • On Databricks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@BrendBraeckmans BrendBraeckmans requested a review from a team as a code owner June 12, 2024 12:53
dannymeijer
dannymeijer approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@dannymeijer dannymeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dannymeijer dannymeijer added the enhancement New feature or request label Jun 12, 2024
@dannymeijer dannymeijer linked an issue Jun 12, 2024 that may be closed by this pull request
[FEATURE] Add streaming option to FileLoader #50
Closed
@BrendBraeckmans BrendBraeckmans merged commit 2d1449e into Nike-Inc:main Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannymeijer dannymeijer dannymeijer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Koheesio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add streaming option to FileLoader
2 participants
@BrendBraeckmans @dannymeijer