Ability to read Excel files #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduces pandas module - abstracted Reader class to a common BaseReader (as part of models module) - re-implemented spark.readers.Reader based on BaseReader - introduces ExcelReader at koheesio.pandas.readers.excel.ExcelReader - introduces ExcelReader at koheesio.spark.reader.excel.ExcelReader - added unittests to cover the above - added excel extra dependency - added docs
- introduces pandas module - abstracted Reader class to a common BaseReader (as part of models module) - re-implemented spark.readers.Reader based on BaseReader - introduces ExcelReader at koheesio.pandas.readers.excel.ExcelReader - introduces ExcelReader at koheesio.spark.reader.excel.ExcelReader - added unittests to cover the above - added excel extra dependency - added docs
This reverts commit ef7c934.
dannymeijer
force-pushed
the
3-feature-excel-filereader
branch
from
e61f37a
to
c06af46
Compare
|
Potentially can be integrated with Box. We already have CSV reader there, Excel could be a valuable addition. |
dannymeijer
force-pushed
the
3-feature-excel-filereader
branch
from
ea57491
to
a8b74f2
Compare
dannymeijer
force-pushed
the
3-feature-excel-filereader
branch
from
a8b74f2
to
4f53a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#3
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: