-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/brickflow examples #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pariksheet
requested review from
asingamaneni,
stikkireddy,
newfront and
a team
as code owners
September 8, 2023 13:44
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 22 22
Lines 3169 3169
=======================================
Hits 2802 2802
Misses 367 367 ☔ View full report in Codecov by Sentry. |
asingamaneni
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
asingamaneni
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the example workflow available in brickflow repo does not work.
Description
Example still refers to 0.8.0 version which breaks with 0.10.0 version.
Related Issue
Updated readme of example with verbose steps
Motivation and Context
Many people have shown interest in brickflow, working example will help user to get started.
How Has This Been Tested?
Tested locally by following the steps in Readme file of example directory.
Screenshots (if appropriate):
Checklist: