Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/brickflow examples #36

Merged
merged 9 commits into from
Sep 9, 2023

Conversation

pariksheet
Copy link
Collaborator

@pariksheet pariksheet commented Sep 8, 2023

the example workflow available in brickflow repo does not work.

Description

Example still refers to 0.8.0 version which breaks with 0.10.0 version.

Related Issue

Updated readme of example with verbose steps

Motivation and Context

Many people have shown interest in brickflow, working example will help user to get started.

How Has This Been Tested?

Tested locally by following the steps in Readme file of example directory.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (273fe7e) 88.41% compared to head (064c1f7) 88.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          22       22           
  Lines        3169     3169           
=======================================
  Hits         2802     2802           
  Misses        367      367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni added bug Something isn't working documentation Improvements or additions to documentation labels Sep 9, 2023
@asingamaneni asingamaneni merged commit 9d960df into Nike-Inc:main Sep 9, 2023
4 checks passed
@pariksheet pariksheet deleted the fix/brickflow-examples branch July 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants