Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support runtime project params #147

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Support runtime project params #147

merged 10 commits into from
Aug 20, 2024

Conversation

pariksheet
Copy link
Collaborator

@pariksheet pariksheet commented Aug 8, 2024 •
edited
Loading

Description

Related Issue

#65

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

asingamaneni
asingamaneni approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this contribution

@asingamaneni asingamaneni merged commit 70382e6 into Nike-Inc:main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asingamaneni asingamaneni asingamaneni approved these changes

@stikkireddy stikkireddy Awaiting requested review from stikkireddy stikkireddy is a code owner

@newfront newfront Awaiting requested review from newfront newfront is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pariksheet @asingamaneni