-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added supported parameter varaiable and removed Deprecated ones #134
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: NARESH NALLA <[email protected]>
Signed-off-by: NARESH NALLA <[email protected]>
Added below parameter varaiables
|
Signed-off-by: NARESH NALLA <[email protected]>
Signed-off-by: NARESH NALLA <[email protected]>
Signed-off-by: NARESH NALLA <[email protected]>
Signed-off-by: NARESH NALLA <[email protected]>
Signed-off-by: NARESH NALLA <[email protected]>
Signed-off-by: NARESH NALLA <[email protected]>
# 2 braces to escape for 1 | ||
return {i.value: f"{{{{{i.name}}}}}" for i in BrickflowBuiltInTaskVariables} | ||
mapping = { | ||
"brickflow_job_id": "{{job.id}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not just change the BrickflowBuiltInTaskVariables
class to something like below and make changes accordingly? This will avoid maintaining the mapping at both places
class BrickflowBuiltInTaskVariables(Enum):
# key is the {{ }} and value is the key
brickflow_job_id = "{{job.id}}"
brickflow_run_id = "{{task.run_id}}"
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naresh483 do we need to close this pr?
Description
Added below parameter varaiables
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: