Backfill overlap avoidance #3872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made two major mistakes in this PR: #3557
And it is not working.
I believe this PR is a solution.
My first mistake was that I overlooked that there are two different lines in the code that auto start a sensor for a session in progress. That PR attempted to address only one of them (Ob1G5StateMachine) and not the other (Home).
My second mistake was that I incorrectly used a method for finding last readings overlooking the need to ignore the sensor. By not ignoring the sensor, the method would detect that there is no local session and return null causing a full backfill causing overlap.
This PR addresses those two oversights. It also addresses a cosmetic issue. It creates a log (and start flag notification) showing that we have started an internal session because there is a session in progress on G7.
Tests
I have tested G6 to G7. The following shows an Android 11 Motorola.
I will test G7 to G7 in 5 days and report the results here.