-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent High Alert threshold fix #3729
Conversation
Why a notification? |
This clip shows that it takes 10 seconds for the toast to come up with the data source set to Nightscout follower. PHA_Range.mp4 |
I have tested this on Android 8, 9 and 11. |
I don't really know what you're doing here. Why don't you just return false from the onPreferenceChange listener if you want to reject the new value? https://developer.android.com/reference/android/preference/Preference.OnPreferenceChangeListener |
Thanks for this. Apparently, I misunderstood that this was possible. I thought that the listener informed us after the preference changed not before. Thanks |
OMG! It just takes a few lines to do all of this when doing it the right way, meaning when you know Java! I need to take a class. Thanks so much for catching this. |
I forgot to include verification for the threshold range. This PR adds that.
We wait for the threshold to be changed to trigger a listener. Then, we fix it if the value is out of range.
This means that in the meantime, the alert could be using an incorrect threshold.
Also, if the app crashes just after a new threshold is added but before verification, it will never be corrected.
To avoid those, I have added a second preference. The alert only uses the second setting. This effectively isolates the alert from transitionary changes the UI setting may experience.
There is no before/after because there is no change to how the user interface looks. The new setting is invisible.
I wish I knew a way to accomplish these simple objectives with a PR much smaller than this.
I am open to suggestions.
I have intentionally left everything in English. After this is used and tested and verified, I will open a PR and add all the new text to strings so that they can be translated.
Thanks