Dex Share cleanup #3659
Merged
Dex Share cleanup #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes.
1- Removes the ability to edit the test mode RX serial number.
This setting is available under engineering mode only. After this PR, it will not be available even in engineering mode.
2- Removes the Dexcom receiver serial number setting from the Dex share menu.
This setting should not be changed and as such has no purpose any longer.
3- Removes the option to manage followers from the Dex share menu.
This option has no purpose as it is not possible to manage followers from xDrip any longer.
4- Strings have been updated.
Users often misunderstand Dex share with Clarity. xDrip cannot upload to Clarity. Many users see the current Dex share setting and because it is not clearly identified, they expect it to upload to Clarity.
There may be a copyright on the word Dexcom. It has been replaced with Dex.
Before and After are shown below.
This is tested and ready for review.