Disable "Restart Sensor" when incompatible #3572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will disable
Restart Sensor
for devices that cannot be restarted.Without this, an inexperienced user may enable the setting and when the time comes for the next sensor, it may take up to half an hour for their restart attempt to fail and be obvious that something may be wrong.
I have also seen a case where the failure would happen in just a few minutes, but it would attempt another restart.
The user had posted on facebook asking for help.
It took quite a while to realize that they had enabled restart sensor for a new G6.
I cannot think of any case that would be at a disadvantage after including this. Can you think of a scenario where this PR would disable restart sensor where it would actually be possible?
G5 and very old G6 devices are the only ones that can benefit from enabling restart sensor. This PR does not change that. They will still be able to enable, and use, restart.