-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insulin profile list not showing all insulin profiles #3177
Conversation
…ot showing all insulin profiles.
…nding .txt to have the file ending .json
@jamorham Could you have a look at this? I think this is something that should be fixed before the next stable release. |
There is a (user) workaround. If the user goes to Android settings and enables the setting that allows the orientation to automatically change between landscape and portrait based on gravity, rotating the phone to landscape mode will allow the user to scroll through the list. |
Hi, thanks for this. Notes about this PR:
|
1.) Done. Tested it on my OnePlus Nord 2 5G and several devices in Android Studio Emulator. Worked fine on all devices. 2.) The previous layout used two nested ScrollViews, with the inner scroll view being a fixed height of 440dp. This caused problems depending on the screen resolution. I changed this to one ScrollView containing all the content and matching the height to wrap the content, dynamically adjusting to the screen resolution. 3.) The correct file extension for JSON files is Also, thank you for updating the configuration so the project works with an up-to-date version of Android Studio now. |
You make a good argument regarding json file extension. I may be quoting how things were in 2016 with android studio. |
There are no changes to the actual content of the file. I just changed the file extension and did an auto-format (Ctrl+Alt+L) with Android Studio. From what I can tell, everything works fine. |
As @Navid200 mentioned in #3157, the current insulin profile list has a fixed size and does not show all insulin profiles.
This PR fixes that by changing the fixed vertical size to a dynamic size based on the content.
Before (Notice the missing FIASP which should be at the top:
After (depending on the screen size/resolution you need to scroll down to see the buttons):