Update DRGEP to work with Cantera 3.0 #84
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anthony-walker @kyleniemeyer, I 've completed this. PyMARS works fine with Cantera 3.0 and it uses the preconditioner. The thing is, I've not done the edits using GitHub so will fork and copy the edits there.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kyleniemeyer I updated part of pyMARS to use Cantera 3.0 which relies on
yamlfiles and notcti. I also wanted to use preconditioning in the reduction to hopefully accelerate the process for a large model. Specifically I updateddrgepfunctions as that is what applies to my work. I am opening this PR so if there is a need/desire to updatepyMARScompletely in the future then there is at least a starting point for that. As it stands, I haven't tested pyMARS with the changes I have made past what I needed to reduce my model.