Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use Windows 10 graphics capture to record #751

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

h82258652
Copy link

Hello, I have used ScreenToGif for several years. Record a window is always a bad hurt. These days I'm playing the Windows 10 graphics capture and I notice ScreenToGif can use it to record the window.

I implemented the basic function, it works well on my machine.
But I need bits of help such as icon, localization and test on old Windows version.

@NickeManarin
Copy link
Owner

It's a good feature, Just the user experience could be improved.

Perhaps this feature can be inserted inside the screen recorders?

Anyway, there's a bug. The first frame recorded always has a different size than the rest. Different sized frames are currently not supported by the editor and encoder.

@h82258652
Copy link
Author

@NickeManarin
Strange bug, I will have a look tomorrow.
I don't think it should be inserted inside the screen recorders because they should have a different UI. (I still use the old style screen recorder:blush:).

By the way, I will continue to implement the pause function. But I think it will take few days, there is too little information about graphics capture and busy these days in real.

@h82258652
Copy link
Author

Found the problem.
GraphicsCaptureItem.Size means the window content size + border + out shadow.
Direct3D11CaptureFrame.ContentSize means the window content size + border.
And the code fixed now. All the frames size equals GraphicsCaptureItem.Size.

@h82258652
Copy link
Author

The pause function is implemented now. The next should be discarded.

@FaithfulDev
Copy link

FaithfulDev commented Dec 5, 2023

My feedback as a long-time ScreenToGif user regarding @NickeManarin comments to user experience:

I like this feature. I just tested it locally on my machine and capturing windows is much easier with it.

I would consider it as an alternative to the screen recorder, just like the whiteboard recorder, and I can see, why it is placed in the startup window. At the same time, I do feel like there is a weird relationship between this new feature and the "snap to window" function of the screen recorder. I think this feature is superior to the "snap to window" and I don't see, why I would ever want to "snap", if I instead could "system capture" it.

Regardless, I dare to disagree with @NickeManarin 😓 and would say, placing it in the screen recorder window would feel weird, since it behaves radically different from the other area selectors, as the others always allow me to adjust the area afterward and the system capture would be fixed and "sticky" (meaning it moves with the window). For me, this is a different recording method and thus belongs on the startup. Users are used to selecting "how" they record in the startup.

@h82258652 It's sad that this PR became stale. I would have loved to have this all these years. Kudos for the idea and the work you put in. Hope this PR is revived someday 😀

@ArudoPE
Copy link

ArudoPE commented Oct 2, 2024

I hope to see this become a reality too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants