[10.x] Ensureschema:dump will dump the migrations table only if it …

…exists (laravel#51827) * fix: migrations table must only be dumped on default connection * fix: migrations table must only be dumped on default connection * Style * Use `$this->connection->getSchemaBuilder()->hasTable()` instead of `Config::get()`` * Update SchemaState.php --------- Co-authored-by: Taylor Otwell <[email protected]>
NickSdot · Jun 19, 2024 · f7ea4e9 · f7ea4e9
1 parent 16472d1
commit f7ea4e9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/src/Illuminate/Database/Schema/MySqlSchemaState.php b/src/Illuminate/Database/Schema/MySqlSchemaState.php
@@ -26,7 +26,9 @@ public function dump(Connection $connection, $path)
 
         $this->removeAutoIncrementingState($path);
 
-        $this->appendMigrationData($path);
+        if ($this->hasMigrationTable()) {
+            $this->appendMigrationData($path);
+        }
     }
 
     /**

diff --git a/src/Illuminate/Database/Schema/PostgresSchemaState.php b/src/Illuminate/Database/Schema/PostgresSchemaState.php
@@ -17,9 +17,12 @@ public function dump(Connection $connection, $path)
     {
         $commands = collect([
             $this->baseDumpCommand().' --schema-only > '.$path,
-            $this->baseDumpCommand().' -t '.$this->migrationTable.' --data-only >> '.$path,
         ]);
 
+        if ($this->hasMigrationTable()) {
+            $commands->push($this->baseDumpCommand().' -t '.$this->migrationTable.' --data-only >> '.$path);
+        }
+
         $commands->map(function ($command, $path) {
             $this->makeProcess($command)->mustRun($this->output, array_merge($this->baseVariables($this->connection->getConfig()), [
                 'LARAVEL_LOAD_PATH' => $path,

diff --git a/src/Illuminate/Database/Schema/SchemaState.php b/src/Illuminate/Database/Schema/SchemaState.php
@@ -94,6 +94,16 @@ public function makeProcess(...$arguments)
         return call_user_func($this->processFactory, ...$arguments);
     }
 
+    /**
+     * Determine if the current connection has a migration table.
+     *
+     * @return bool
+     */
+    public function hasMigrationTable(): bool
+    {
+        return $this->connection->getSchemaBuilder()->hasTable($this->migrationTable);
+    }
+
     /**
      * Specify the name of the application's migration table.
      *

diff --git a/src/Illuminate/Database/Schema/SqliteSchemaState.php b/src/Illuminate/Database/Schema/SqliteSchemaState.php
@@ -28,7 +28,9 @@ public function dump(Connection $connection, $path)
 
         $this->files->put($path, implode(PHP_EOL, $migrations).PHP_EOL);
 
-        $this->appendMigrationData($path);
+        if ($this->hasMigrationTable()) {
+            $this->appendMigrationData($path);
+        }
     }
 
     /**