Updated news.

NicChr · Sep 19, 2024 · 3d17697 · 3d17697
1 parent 8dc7e14
commit 3d17697
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,7 +1,7 @@
 # cheapr (Development version)
 
-* Limited support added for 'integer64' objects when counting and 
-finding `NA` values.
+* Limited support added for 'integer64' objects. This applies to the
+`NA` related functions as well as the GCD and LCM functions.
 
 * New functions `new_df` and `named_dots`.
 

diff --git a/src/gcd.cpp b/src/gcd.cpp
@@ -134,6 +134,9 @@ long long int cpp_lcm2_int64(long long int x, long long int y, bool na_rm){
   // 64-bit integer overflow check
   // Make sure not to divide by zero!
 
+  // res can be an int because the gcd ensures the denom
+  // divides x by a whole number
+
   long long res = std::llabs(x) / cpp_gcd2_int64(x, y, false);
   if (y != 0 && (std::llabs(res) > (LLONG_MAX / std::llabs(y)))){
     Rf_error("64-bit integer overflow, please use doubles");