feat: reduce gas for first vote by validators #2163
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| package ante | ||
|
|
||
| import ( | ||
| sdkerrors "cosmossdk.io/errors" | ||
| "cosmossdk.io/math" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| errortypes "github.com/cosmos/cosmos-sdk/types/errors" | ||
| authsigning "github.com/cosmos/cosmos-sdk/x/auth/signing" | ||
|
|
||
| "github.com/NibiruChain/nibiru/v2/x/oracle/types" | ||
| ) | ||
|
|
||
| // VoteFeeDiscountDecorator checks if the Tx signer is a validator and | ||
| // has or hasn't voted in the current voting period. If it's their first time, | ||
| // we apply a discount on fees or gas. Otherwise, normal cost applies. | ||
| // | ||
| // In real code, you'll likely store more config, such as a reference to the | ||
| // staking keeper to fetch validator info, or track the current epoch. | ||
| type VoteFeeDiscountDecorator struct { | ||
| oracleKeeper OracleKeeperI | ||
| stakingKeeper StakingKeeperI | ||
| } | ||
|
|
||
| // NewVoteFeeDiscountDecorator is the constructor. | ||
| func NewVoteFeeDiscountDecorator( | ||
| oracleKeeper OracleKeeperI, | ||
| stakingKeeper StakingKeeperI, | ||
| ) VoteFeeDiscountDecorator { | ||
| return VoteFeeDiscountDecorator{ | ||
| oracleKeeper: oracleKeeper, | ||
| stakingKeeper: stakingKeeper, | ||
| } | ||
| } | ||
|
|
||
| // AnteHandle implements sdk.AnteDecorator. The discount logic is | ||
| // purely demonstrative; adapt to your own logic. | ||
| func (vfd VoteFeeDiscountDecorator) AnteHandle( | ||
| ctx sdk.Context, | ||
| tx sdk.Tx, | ||
| simulate bool, | ||
| next sdk.AnteHandler, | ||
| ) (newCtx sdk.Context, err error) { | ||
| // 1. We check if there's exactly one signer (typical for Oracle votes). | ||
| // If your chain supports multiple signers, adapt accordingly. | ||
| sigTx, ok := tx.(authsigning.SigVerifiableTx) | ||
| if !ok { | ||
| return ctx, sdkerrors.Wrapf(errortypes.ErrTxDecode, "invalid tx type %T", tx) | ||
| } | ||
|
|
||
| sigs, err := sigTx.GetSignaturesV2() | ||
| if err != nil { | ||
| return next(ctx, tx, simulate) | ||
| } | ||
| if len(sigs) != 1 { | ||
| // passthrough if not exactly one signer | ||
| return next(ctx, tx, simulate) | ||
| } | ||
|
|
||
| // ensure all messages are prevoting or voting messages | ||
| for _, msg := range tx.GetMsgs() { | ||
| if _, ok := msg.(*types.MsgAggregateExchangeRatePrevote); !ok { | ||
| if _, ok := msg.(*types.MsgAggregateExchangeRateVote); !ok { | ||
| return next(ctx, tx, simulate) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // 2. Check if the signer is a validator | ||
| valAddr := sdk.ValAddress(sigTx.GetSigners()[0]) | ||
| validator, found := vfd.stakingKeeper.GetValidator(ctx, valAddr) | ||
| if !found { | ||
| return next(ctx, tx, simulate) | ||
| } | ||
|
|
||
| if validator.Jailed { | ||
| return next(ctx, tx, simulate) | ||
| } | ||
|
|
||
| // needs to have at least 0.5% of the supply bonded | ||
| totalBonded := vfd.stakingKeeper.TotalBondedTokens(ctx) | ||
| currentlyBonded := validator.Tokens | ||
|
|
||
| if currentlyBonded.LT(totalBonded.Mul(math.NewInt(50)).Quo(math.NewInt(10000))) { | ||
| return next(ctx, tx, simulate) | ||
| } | ||
|
|
||
| // 3. If validator, we check whether they've posted a vote this period | ||
| hasVoted := vfd.oracleKeeper.HasVotedInCurrentPeriod(ctx, valAddr) | ||
| if !hasVoted { | ||
| // 4. If first time, let's say we reduce gas cost. | ||
| minGasPrices := ctx.MinGasPrices() | ||
| var discounted []sdk.DecCoin | ||
| for _, mgp := range minGasPrices { | ||
| discounted = append(discounted, sdk.NewDecCoinFromDec(mgp.Denom, mgp.Amount.QuoInt64(69_420))) | ||
| } | ||
| // We'll create a new context with the updated MinGasPrices | ||
| ctx = ctx.WithMinGasPrices(discounted) | ||
| } | ||
|
Comment on lines
+87
to
+98
There was a problem hiding this comment. Ensure Gas Discount Logic Correctly Applies Discounts The gas price reduction divides the Consider revising the discount factor to a more appropriate value or making it configurable. Apply this diff to adjust the discount factor: - discounted = append(discounted, sdk.NewDecCoinFromDec(mgp.Denom, mgp.Amount.QuoInt64(69_420)))
+ discountFactor := sdk.NewDecWithPrec(5, 1) // 50% discount
+ discountedAmount := mgp.Amount.Mul(discountFactor)
+ discounted = append(discounted, sdk.NewDecCoinFromDec(mgp.Denom, discountedAmount))
|
||
|
|
||
| // 5. Keep going in the AnteHandler chain | ||
| return next(ctx, tx, simulate) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Adjust Bonded Tokens Threshold Calculation for Precision
The calculation for determining if a validator has at least 0.5% of the bonded tokens (line 83) uses integer arithmetic, which may lead to imprecise results due to truncation. Consider using precise decimal arithmetic with
sdk.Decto ensure accuracy in the threshold calculation.Apply this diff to enhance precision:
📝 Committable suggestion