Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evm): proper tx gas refund outside of CallContract #2132

Merged
merged 18 commits into from
Jan 14, 2025

test: fixed tests after merge

0932e28
Select commit
Loading
Failed to load commit list.
Merged

fix(evm): proper tx gas refund outside of CallContract #2132

test: fixed tests after merge
0932e28
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 0s

65.23% (target 60.00%)

View this Pull Request on Codecov

65.23% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 65.23%. Comparing base (8c6e021) to head (0932e28).

Files with missing lines Patch % Lines
x/evm/keeper/msg_server.go 46.15% 5 Missing and 2 partials ⚠️
x/evm/keeper/funtoken_from_coin.go 42.85% 3 Missing and 1 partial ⚠️
x/evm/keeper/keeper.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2132      +/-   ##
==========================================
+ Coverage   65.21%   65.23%   +0.02%     
==========================================
  Files         277      277              
  Lines       22197    22214      +17     
==========================================
+ Hits        14475    14491      +16     
  Misses       6732     6732              
- Partials      990      991       +1     
Files with missing lines Coverage Δ
x/evm/keeper/call_contract.go 90.00% <ø> (+5.71%) ⬆️
x/evm/keeper/keeper.go 68.51% <50.00%> (+0.59%) ⬆️
x/evm/keeper/funtoken_from_coin.go 74.19% <42.85%> (-3.99%) ⬇️
x/evm/keeper/msg_server.go 76.60% <46.15%> (-0.40%) ⬇️

... and 2 files with indirect coverage changes