test(evm): unit tests for evm_ante

CHANGELOG.md

@@ -69,6 +69,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#1901](https://github.com/NibiruChain/nibiru/pull/1901) - test(evm): more e2e test contracts for edge cases
 - [#1907](https://github.com/NibiruChain/nibiru/pull/1907) - test(evm): grpc_query full coverage
 - [#1909](https://github.com/NibiruChain/nibiru/pull/1909) - chore(evm): set is_london true by default and removed from config
+- [#1912](https://github.com/NibiruChain/nibiru/pull/1912) - test(evm): unit tests for evm_ante_sigverify
 
 #### Dapp modules: perp, spot, oracle, etc
 

app/evmante_emit_event.go

@@ -0,0 +1,58 @@
+// Copyright (c) 2023-2024 Nibi, Inc.
+package app
+
+import (
+	"strconv"
+
+	errorsmod "cosmossdk.io/errors"
+	"github.com/NibiruChain/nibiru/x/evm"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	errortypes "github.com/cosmos/cosmos-sdk/types/errors"
+)
+
+// EthEmitEventDecorator emit events in ante handler in case of tx execution failed (out of block gas limit).
+type EthEmitEventDecorator struct {
+	AppKeepers
+}
+
+// NewEthEmitEventDecorator creates a new EthEmitEventDecorator
+func NewEthEmitEventDecorator(k AppKeepers) EthEmitEventDecorator {
+	return EthEmitEventDecorator{AppKeepers: k}
+}
+
+// AnteHandle emits some basic events for the eth messages
+func (eeed EthEmitEventDecorator) AnteHandle(
+	ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler,
+) (newCtx sdk.Context, err error) {
+	// After eth tx passed ante handler, the fee is deducted and nonce increased,
+	// it shouldn't be ignored by json-rpc. We need to emit some events at the
+	// very end of ante handler to be indexed by the consensus engine.
+	txIndex := eeed.EvmKeeper.EVMState().BlockTxIndex.GetOr(ctx, 0)
+
+	for i, msg := range tx.GetMsgs() {
+		msgEthTx, ok := msg.(*evm.MsgEthereumTx)
+		if !ok {
+			return ctx, errorsmod.Wrapf(
+				errortypes.ErrUnknownRequest,
+				"invalid message type %T, expected %T",
+				msg, (*evm.MsgEthereumTx)(nil),
+			)
+		}
+
+		// emit ethereum tx hash as an event so that it can be indexed by
+		// Tendermint for query purposes it's emitted in ante handler, so we can
+		// query failed transaction (out of block gas limit).
+		ctx.EventManager().EmitEvent(
+			sdk.NewEvent(
+				evm.EventTypeEthereumTx,
+				sdk.NewAttribute(evm.AttributeKeyEthereumTxHash, msgEthTx.Hash),
+				sdk.NewAttribute(
+					evm.AttributeKeyTxIndex, strconv.FormatUint(txIndex+uint64(i),
+						10,
+					),
+				), // #nosec G701
+			))
+	}
+
+	return next(ctx, tx, simulate)
+}

app/evmante_emit_event_test.go

@@ -0,0 +1,78 @@
+package app_test
+
+import (
+	"github.com/NibiruChain/nibiru/x/evm"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/auth/migrations/legacytx"
+
+	"github.com/NibiruChain/nibiru/app"
+	"github.com/NibiruChain/nibiru/x/evm/evmtest"
+	tf "github.com/NibiruChain/nibiru/x/tokenfactory/types"
+)
+
+func (s *TestSuite) TestEthEmitEventDecorator() {
+	testCases := []struct {
+		name    string
+		txSetup func(deps *evmtest.TestDeps) sdk.Tx
+		wantErr string
+	}{
+		{
+			name: "sad: non ethereum tx",
+			txSetup: func(deps *evmtest.TestDeps) sdk.Tx {
+				return legacytx.StdTx{
+					Msgs: []sdk.Msg{
+						&tf.MsgMint{},
+					},
+				}
+			},
+			wantErr: "invalid message",
+		},
+		{
+			name: "happy: eth tx emitted event",
+			txSetup: func(deps *evmtest.TestDeps) sdk.Tx {
+				tx := happyCreateContractTx(deps)
+				return tx
+			},
+			wantErr: "",
+		},
+	}
+
+	for _, tc := range testCases {
+		s.Run(tc.name, func() {
+			deps := evmtest.NewTestDeps()
+			stateDB := deps.StateDB()
+			anteDec := app.NewEthEmitEventDecorator(deps.Chain.AppKeepers)
+
+			tx := tc.txSetup(&deps)
+			s.Require().NoError(stateDB.Commit())
+
+			_, err := anteDec.AnteHandle(
+				deps.Ctx, tx, false, NextNoOpAnteHandler,
+			)
+			if tc.wantErr != "" {
+				s.Require().ErrorContains(err, tc.wantErr)
+				return
+			}
+			s.Require().NoError(err)
+			events := deps.Ctx.EventManager().Events()
+
+			s.Require().Greater(len(events), 0)
+			event := events[len(events)-1]
+			s.Require().Equal(evm.EventTypeEthereumTx, event.Type)
+
+			// Convert tx to msg to get hash
+			txMsg, ok := tx.GetMsgs()[0].(*evm.MsgEthereumTx)
+			s.Require().True(ok)
+
+			// TX hash attr must present
+			attr, ok := event.GetAttribute(evm.AttributeKeyEthereumTxHash)
+			s.Require().True(ok, "tx hash attribute not found")
+			s.Require().Equal(txMsg.Hash, attr.Value)
+
+			// TX index attr must present
+			attr, ok = event.GetAttribute(evm.AttributeKeyTxIndex)
+			s.Require().True(ok, "tx index attribute not found")
+			s.Require().Equal("0", attr.Value)
+		})
+	}
+}

app/evmante_gas_wanted_test.go

@@ -0,0 +1,106 @@
+package app_test
+
+import (
+	tmproto "github.com/cometbft/cometbft/proto/tendermint/types"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/auth/migrations/legacytx"
+
+	"github.com/NibiruChain/nibiru/app"
+	"github.com/NibiruChain/nibiru/x/evm/evmtest"
+)
+
+func (s *TestSuite) TestGasWantedDecorator() {
+	testCases := []struct {
+		name     string
+		ctxSetup func(deps *evmtest.TestDeps)
+		txSetup  func(deps *evmtest.TestDeps) sdk.Tx
+		wantErr  string
+	}{
+		{
+			name: "happy: non fee tx type",
+			txSetup: func(deps *evmtest.TestDeps) sdk.Tx {
+				return happyCreateContractTx(deps)
+			},
+			wantErr: "",
+		},
+		{
+			name: "happy: tx without gas, block gas limit 1000",
+			ctxSetup: func(deps *evmtest.TestDeps) {
+				cp := &tmproto.ConsensusParams{
+					Block: &tmproto.BlockParams{MaxGas: 1000},
+				}
+				deps.Ctx = deps.Ctx.WithConsensusParams(cp)
+			},
+			txSetup: func(deps *evmtest.TestDeps) sdk.Tx {
+				return legacytx.StdTx{
+					Msgs: []sdk.Msg{
+						happyCreateContractTx(deps),
+					},
+				}
+			},
+			wantErr: "",
+		},
+		{
+			name: "happy: tx with gas wanted 500, block gas limit 1000",
+			ctxSetup: func(deps *evmtest.TestDeps) {
+				cp := &tmproto.ConsensusParams{
+					Block: &tmproto.BlockParams{MaxGas: 1000},
+				}
+				deps.Ctx = deps.Ctx.WithConsensusParams(cp)
+			},
+			txSetup: func(deps *evmtest.TestDeps) sdk.Tx {
+				return legacytx.StdTx{
+					Msgs: []sdk.Msg{
+						happyCreateContractTx(deps),
+					},
+					Fee: legacytx.StdFee{Gas: 500},
+				}
+			},
+			wantErr: "",
+		},
+		{
+			name: "sad: tx with gas wanted 1000, block gas limit 500",
+			ctxSetup: func(deps *evmtest.TestDeps) {
+				cp := &tmproto.ConsensusParams{
+					Block: &tmproto.BlockParams{
+						MaxGas: 500,
+					},
+				}
+				deps.Ctx = deps.Ctx.WithConsensusParams(cp)
+			},
+			txSetup: func(deps *evmtest.TestDeps) sdk.Tx {
+				return legacytx.StdTx{
+					Msgs: []sdk.Msg{
+						happyCreateContractTx(deps),
+					},
+					Fee: legacytx.StdFee{Gas: 1000},
+				}
+			},
+			wantErr: "exceeds block gas limit",
+		},
+	}
+
+	for _, tc := range testCases {
+		s.Run(tc.name, func() {
+			deps := evmtest.NewTestDeps()
+			stateDB := deps.StateDB()
+			anteDec := app.NewGasWantedDecorator(deps.Chain.AppKeepers)
+
+			tx := tc.txSetup(&deps)
+			s.Require().NoError(stateDB.Commit())
+
+			deps.Ctx = deps.Ctx.WithIsCheckTx(true)
+			if tc.ctxSetup != nil {
+				tc.ctxSetup(&deps)
+			}
+			_, err := anteDec.AnteHandle(
+				deps.Ctx, tx, false, NextNoOpAnteHandler,
+			)
+			if tc.wantErr != "" {
+				s.Require().ErrorContains(err, tc.wantErr)
+				return
+			}
+			s.Require().NoError(err)
+		})
+	}
+}