test(cli_test): test for specific errors rather than boolean checks

NibiruChain · Dec 28, 2023 · c4c24ca · c4c24ca
1 parent 48bf7c6
commit c4c24ca
Showing 1 changed file with 16 additions and 15 deletions.
diff --git a/x/devgas/v1/client/cli/cli_test.go b/x/devgas/v1/client/cli/cli_test.go
@@ -82,7 +82,7 @@ type TestCase struct {
 	name      string
 	args      []string
 	extraArgs []string
-	wantErr   bool
+	wantErr   string
 }
 
 func (tc TestCase) NewCtx(s *CLITestSuite) sdkclient.Context {
@@ -101,8 +101,9 @@ func (tc TestCase) Run(s *CLITestSuite) {
 		s.Require().NoError(sdkclient.SetCmdClientContextHandler(tc.NewCtx(s), cmd))
 
 		err := cmd.Execute()
-		if tc.wantErr {
+		if tc.wantErr != "" {
 			s.Require().Error(err)
+			s.ErrorContains(err, tc.wantErr)
 			return
 		}
 		s.Require().NoError(err)
@@ -117,7 +118,7 @@ func (s *CLITestSuite) TestCmdRegisterFeeShare() {
 			name:      "happy path: devgas register",
 			args:      []string{"register", addrs[0].String(), addrs[1].String()},
 			extraArgs: []string{fmt.Sprintf("--from=%s", s.testAcc.Address)},
-			wantErr:   false,
+			wantErr:   "",
 		},
 		{
 			name: "sad: fee payer",
@@ -126,23 +127,23 @@ func (s *CLITestSuite) TestCmdRegisterFeeShare() {
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 				fmt.Sprintf("--fee-payer=%s", "invalid-fee-payer"),
 			},
-			wantErr: true,
+			wantErr: "decoding bech32 failed",
 		},
 		{
 			name: "sad: contract addr",
 			args: []string{"register", "sadcontract", addrs[1].String()},
 			extraArgs: []string{
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 			},
-			wantErr: true,
+			wantErr: "invalid contract address",
 		},
 		{
-			name: "sad: deployer addr",
-			args: []string{"register", addrs[0].String(), "saddeployer"},
+			name: "sad: withdraw addr",
+			args: []string{"register", addrs[0].String(), "sadwithdraw"},
 			extraArgs: []string{
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 			},
-			wantErr: true,
+			wantErr: "invalid withdraw address",
 		},
 	}
 
@@ -158,7 +159,7 @@ func (s *CLITestSuite) TestCmdCancelFeeShare() {
 			name:      "happy path: devgas cancel",
 			args:      []string{"cancel", addrs[0].String()},
 			extraArgs: []string{fmt.Sprintf("--from=%s", s.testAcc.Address)},
-			wantErr:   false,
+			wantErr:   "",
 		},
 		{
 			name: "sad: fee payer",
@@ -167,15 +168,15 @@ func (s *CLITestSuite) TestCmdCancelFeeShare() {
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 				fmt.Sprintf("--fee-payer=%s", "invalid-fee-payer"),
 			},
-			wantErr: true,
+			wantErr: "decoding bech32 failed",
 		},
 		{
 			name: "sad: contract addr",
 			args: []string{"cancel", "sadcontract"},
 			extraArgs: []string{
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 			},
-			wantErr: true,
+			wantErr: "invalid deployer address",
 		},
 	}
 
@@ -192,7 +193,7 @@ func (s *CLITestSuite) TestCmdUpdateFeeShare() {
 			name:      "happy path: devgas update",
 			args:      []string{"update", addrs[0].String(), addrs[1].String()},
 			extraArgs: []string{fmt.Sprintf("--from=%s", s.testAcc.Address)},
-			wantErr:   false,
+			wantErr:   "",
 		},
 		{
 			name: "sad: fee payer",
@@ -201,23 +202,23 @@ func (s *CLITestSuite) TestCmdUpdateFeeShare() {
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 				fmt.Sprintf("--fee-payer=%s", "invalid-fee-payer"),
 			},
-			wantErr: true,
+			wantErr: "decoding bech32 failed",
 		},
 		{
 			name: "sad: contract addr",
 			args: []string{"update", "sadcontract", addrs[1].String()},
 			extraArgs: []string{
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 			},
-			wantErr: true,
+			wantErr: "invalid contract",
 		},
 		{
 			name: "sad: new withdraw addr",
 			args: []string{"update", addrs[0].String(), "saddeployer"},
 			extraArgs: []string{
 				fmt.Sprintf("--from=%s", s.testAcc.Address),
 			},
-			wantErr: true,
+			wantErr: "invalid withdraw address",
 		},
 	}