Cleaned The Code, Minor Bug Fixes #5
Conversation
whokilleddb
commented
Jul 19, 2021
whokilleddb
commented
- Replaced Banner With Simple Titles(Looks Cleaner)
- Added Better Command Line Interface with flags
- Used Menu Based Navigation
- Now The Script Can Be Run From Anywhere In the File System
- Minor Bug Fixes
…s, Minor Bug Fixes, etc
|
@whokilleddb Thanks for working on this really improved the the experience. @Nibba2018 Thanks to you too ❤️ |
There was a problem hiding this comment.
Hello @whokilleddb , Thanks for the PR. I have resolved the existing conflicts and have added some comments below after which it should be ready to be merged.
Also, the test.mp4 is quite big in size for a test file(~15mb). It would be better to have a lighter video. (smaller resolution or smaller video length).
Thanks!
|
|
||
|  | ||
|
|
||
|
|
||
| Cheers!! |
There was a problem hiding this comment.
The screenshot needs to be updated. It still uses the old one.
| OPTIONS : | ||
| -h, --help Show This Menu | ||
| -s, --source Stream Desktop | ||
| -v, --video$CYAN FILENAME$NONE Path to Video/Image | ||
| """ |
There was a problem hiding this comment.
I prefer the usage where you just provide the file path for the video stream without any additional flags.
It will be more convenient and backwards compatible to accept video file paths by default. (Not forcing the user to use -v flag).
