did-simple: implement varint encoding #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please give this an actual review, not just a lgtm stamp |
TheButlah
force-pushed
the
thebutlah/encode_varint
branch
from
6c6da1b to
f8e9c6c
Compare
TheButlah
force-pushed
the
thebutlah/encode_varint
branch
from
f8e9c6c to
07afa0f
Compare
TheButlah
changed the title
TheButlah
changed the title
TheButlah
force-pushed
the
thebutlah/encode_varint
branch
from
0c19d66 to
07afa0f
Compare
TheButlah
force-pushed
the
thebutlah/encode_varint
branch
from
07afa0f to
0962abe
Compare
TheButlah
added a commit
that referenced
this pull request
May 19, 2024
rebased on #96, merge that first.
TheButlah
force-pushed
the
thebutlah/encode_varint
branch
from
6d03ed4 to
0962abe
Compare
TheButlah
force-pushed
the
thebutlah/encode_varint
branch
from
0962abe to
bc96ea0
Compare
lyuma
approved these changes
May 20, 2024
There was a problem hiding this comment.
Seems ok from my limited understanding of Rust, There are three cases: 1, 2 and 3 byte length, and each of the three cases should work.
I have a comment about the 0 case, since that should fall under case 1, but it seems to return length 0 instead, and I'm not sure if that is legal within the contract of this API
TheButlah
added a commit
that referenced
this pull request
May 20, 2024
rebased on #96, merge that first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements varint encoding in a const fn.