Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RecyclerConverterAdapter's ViewHolder overrideable #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DSteve595
Copy link

This allows subclasses of RecyclerConverterAdapter to also use their own subclasses of RecyclerConverterAdapter.ViewHolder. This enables the use of AdvancedRecyclerView's (https://github.com/h6ah4i/android-advancedrecyclerview) drag-and-drop, which requires that ViewHolders implement a certain interface.

This allows subclasses of RecyclerConverterAdapter to also use their own subclasses of RecyclerConverterAdapter.ViewHolder. This enables the use of AdvancedRecyclerView's (https://github.com/h6ah4i/android-advancedrecyclerview) drag-and-drop, which requires that ViewHolders implement a certain interface.
@BenTilbrook
Copy link
Collaborator

Might also need to expose RecyclerViewContainer, and perhaps a factory function for creating
the ViewHolders. I'd like to look into this a bit myself later, since I want to carefully manage the API of RecyclerConverterAdapter to avoid exposing unnecessary details. In the mean time, copy the RecyclerConverterAdapter source into your code base and we can discuss any interoperability issues you run into.

See #48

@DSteve595
Copy link
Author

Gotcha. That's what I'm currently doing, and so far I haven't needed to extend the container. A ViewHolder factory would solve my issue,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants