Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade SDK project to .NET Standard 2.1 and Tests and Examples proje… #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade SDK project to .NET Standard 2.1 and Tests and Examples proje… #16

wants to merge 1 commit into from

Conversation

pundj
Copy link

@pundj pundj commented Mar 10, 2021

…cts to .NET 5.0

@pundj
Copy link
Author

pundj commented Mar 10, 2021

I did not mess with package version numbers because that should be up to you as to how you want to version these. This is a fix for #5

@pundj pundj mentioned this pull request Mar 10, 2021
@mmollick
Copy link
Contributor

Hey @pundj thanks for putting this together. Doing some quick reading over .Net 5, it seems .Net Framework 4 is still supported.
Would the updates you've made allow this package to continue to work in .Net Framework 4? Or would this break support for it?

@pundj
Copy link
Author

pundj commented Mar 11, 2021

@mmollick Well, after looking further, it seems .NET Standard 2.1 is only compatible with .NET Core 3.0 and up and not compatible at all with .NET Framework. So, as mentioned in #5, it might be good to create a new repo where you have a separate package with support for .NET Core and .NET (Microsoft unified .NET Framework and .NET Core into a single .NET, which right now the latest supported version is .NET 5, and are putting all their eggs in that basket going forward).

Alternatively, if I downgrade the SDK project to target .NET Standard 2.0 instead of 2.1, that would be compatible with .NET 5 and up, .NET Core 2.0 and up, and .NET Framework 4.6.1 and up. Support chart here: .NET Standard Implementation Support

It would be very easy to downgrade from 2.1 to 2.0 if you want. Or if you would like to create a new repo, you could use this code as a starting point, depending on what .NET Core and unified .NET versions you're hoping to target.

@KeithHenry
Copy link

I've gone a bit further and applied a proper .NET upgrade in https://github.com/EvolutionJobs/NeverBounce

I've applied that fork back here in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants