Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Del unused funcs #2036

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Del unused funcs #2036

wants to merge 4 commits into from

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Feb 7, 2025

Motivation

Move breaking changes from #2031 to this new branch/PR so they can be reviewed and merged separately.

Removed unused functions prepend_string and _not_parent in core.py, _not_parent in file.py, and NWBBaseTypeMapper.get_nwb_file in io/core.py

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (bc12931) to head (81da051).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2036      +/-   ##
==========================================
+ Coverage   91.73%   91.98%   +0.25%     
==========================================
  Files          27       27              
  Lines        2722     2709      -13     
  Branches      710      707       -3     
==========================================
- Hits         2497     2492       -5     
+ Misses        149      141       -8     
  Partials       76       76              
Flag Coverage Δ
integration 73.12% <100.00%> (+0.16%) ⬆️
unit 82.50% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel marked this pull request as ready for review February 7, 2025 22:34
@oruebel oruebel requested review from rly and stephprince February 7, 2025 22:39
@oruebel oruebel mentioned this pull request Feb 7, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant