Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psth use intervals #200

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix handling of trials
bendichter committed Jan 24, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a0c017faf631e4cae57d30086cd82cb4448008b3
17 changes: 12 additions & 5 deletions nwbwidgets/misc.py
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
import plotly.graph_objects as go
import pynwb
import scipy
from ipywidgets import widgets, fixed, FloatProgress, Layout
from ipywidgets import widgets, fixed, FloatProgress, Layout, HTML
from matplotlib.collections import PatchCollection
from matplotlib.patches import Rectangle
from pynwb.misc import AnnotationSeries, Units, DecompositionSeries
@@ -297,29 +297,36 @@ def __init__(

if intervals is None:
all_intervals_tables = self.units.get_ancestor("NWBFile").intervals
trials = self.units.get_ancestor("NWBFile").trials
if trials is not None:
all_intervals_tables.add(trials)
if len(all_intervals_tables) == 0:
self.children = [HTMLWidget("could not find intervals")]
self.children = [HTML("could not find intervals")]
return
elif len(all_intervals_tables) == 1:
self.intervals = next(all_intervals_tables.values())
self.intervals = list(all_intervals_tables.values())[0]
self.intervals_dropdown = None
else:
self.intervals_dropdown = widgets.Dropdown(
options=list(all_intervals_tables),
description="intervals",
)
self.intervals_dropdown.observe(self.intervals_selector_callback)
self.intervals = list(all_intervals_tables.values())[0]
self.intervals = next(all_intervals_tables.values())
else:
if isinstance(intervals, str):
if intervals not in self.units.get_ancestor("NWBFile").intervals:
raise ValueError("'{intervals}' not in NWBFile.intervals")
self.intervals = self.units.get_ancestor("NWBFile").intervals[intervals]
self.intervals_dropdown = None
elif isinstance(intervals, widgets.Dropdown):
self.intervals_dropdown = intervals
self.intervals = self.units.get_ancestor("NWBFile").intervals[self.intervals_dropdown.value]
else:
elif isinstance(intervals, pynwb.epoch.TimeIntervals):
self.intervals = intervals
self.intervals_dropdown = None
else:
raise ValueError("intervals is not an allowable type")

if unit_controller is None:
self.unit_ids = self.units.id.data[:]
1 change: 0 additions & 1 deletion test/test_misc.py
Original file line number Diff line number Diff line change
@@ -93,7 +93,6 @@ def test_psth_widget(self):

def test_multipsth_widget(self):
psth_widget = PSTHWidget(self.nwbfile.units)
assert isinstance(psth_widget, widgets.Widget)
start_labels = ('start_time', 'stop_time')
fig = psth_widget.update(index=0, start_labels=start_labels)
assert len(fig.axes) == 2 * len(start_labels)