Skip to content

Commit

Permalink
Fix elecs region (#195)
Browse files Browse the repository at this point in the history
* move tests outside the nwbwidgets package

* add test for StartAndDurationController

* fix for when electrodes selects subregion of electrodes table
  • Loading branch information
bendichter authored Dec 31, 2021
1 parent 62111e3 commit 0b924c6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions nwbwidgets/controllers/group_and_sort_controllers.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def set_group_by(self, group_by):
if self.column_values is not None:
self.group_sm.layout.visibility = "visible"
self.group_sm.layout.width = "100px"
keep_column_values = self.column_values[self.keep_rows]
keep_column_values = self.column_values
if self.column_values.dtype == np.float:
keep_column_values = keep_column_values[~np.isnan(keep_column_values)]
groups = np.unique(keep_column_values)
Expand Down Expand Up @@ -319,13 +319,13 @@ def range_controller_observer(self, change):
def get_groups(self):
return infer_categorical_columns(self.dynamic_table, self.keep_rows)

def get_column_values(self, column_name, rows_select=None):
def get_column_values(self, column_name: str, rows_select=None):
"""Get the values of the group_by variable
Parameters
----------
by
units_select
column_name: str
rows_select
Returns
-------
Expand Down

0 comments on commit 0b924c6

Please sign in to comment.