Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use in_construct_mode=True for invalid timeseries #556

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 28, 2025

Motivation

Fix #556 in preparation of NeurodataWithoutBorders/pynwb#1538

@rly rly requested a review from stephprince January 28, 2025 21:23
@rly rly enabled auto-merge (squash) January 28, 2025 21:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (cf24e4b) to head (e93e292).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #556      +/-   ##
==========================================
+ Coverage   82.73%   86.77%   +4.03%     
==========================================
  Files          47       47              
  Lines        1512     1512              
==========================================
+ Hits         1251     1312      +61     
+ Misses        261      200      -61     

see 5 files with indirect coverage changes

Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@rly rly merged commit 33ca373 into dev Jan 28, 2025
39 of 40 checks passed
@rly rly deleted the timeseries_invalid_data_test branch January 28, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants