-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file compatibility check #436
Conversation
CC: @stellaprins I think this should catch everything now. |
@sanjayankur31 Looks good. At the end of the day nml & lems toolchain should accpet any suffix for valid nml/lems withoutt failing, but I guess these will only raise warnings, unless you've asked them to fail on mismatch |
Yeh, it checks the extension first, if that does not match what we expect it parses the xml file to figure out the root node of the xml doc. If the root node does not match, it will fail. Should it only warn even then? |
Does this PR also allow *.xml files to be validated as NeuroML?. |
Yes, it will. I'll merge this and cut a release so that it gets used by modelspec etc. |
Hello, I was reading the codebase and wanted to contribute. |
Hi @paritoshparashar , thanks for your interest. I think this issue has been fixed already. (The related issue remains open because the release is made from the development branch and not main) |
No description provided.