Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segment picking ability in 3D #420

Closed
wants to merge 3 commits into from

Conversation

lej0hn
Copy link
Contributor

@lej0hn lej0hn commented Aug 21, 2024

  • Ability to click on any segment and get the InstancedMesh that was clicked
  • Get the instanced_position of said mesh
  • Get info about the corresponding segment*

-TODO

  • Fix type of dictionary keys of positions-segment_infos because the value is right but it throws error
    (to check that error uncomment lines 1219-1220)
  • Add necessary parameters/arguments to plot_schematic_3d

@sanjayankur31
Copy link
Member

Just tested this out---seems to work well, well done! ✨

To begin with, could you maybe please comment the new functions to explain the logic in use there? It'll just make it easier for others to understand how this is all working. So, nice long docstrings that explain the working of the functions would be good.

@sanjayankur31
Copy link
Member

Thanks---it'll also make it easier for us to review :)

@lej0hn
Copy link
Contributor Author

lej0hn commented Aug 21, 2024

Of course, makes sense

@sanjayankur31
Copy link
Member

Replaced by #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants