WinWcpRawIO: Add rec_datetime to header dict and block annotation from file #1733
Conversation
There was a problem hiding this comment.
Thanks for the PR @danielparthier ! Seems like our test file has a different spec where this doesn't exist so could we ask two things:
- could you fix your PR to account for whatever version we have with our test repo to account for the fact not all have "RTIME". We often find with hardware devs they change the keys between versions.
- could you provide a < 10MB test file of the version you're using so we can include it in our testing suite?
|
Thanks for the feedback! I just checked your file on the test repo and it seems it really doesn't have the header. You are right that the version on the test repo seems to be older than 2013. I will get a test file and adjust the code to account for the version difference. |
|
Awesome thanks. We appreciate the update! |
|
I updated the code and added a pull request to the gin repository. Gin didn't like to be run in terminal on my side so I am not 100% it worked because I had to go via the web interface. |
|
GIN/ G-node is super finicky! From the command line it can be a mess. It looks like your PR includes neuralynx and winwcp files. Did you want to try to submit a PR with just the winwcp files? Based on the PR it seems like maybe you're working with @Antho2422 since his name is associated with one of the files? If not then I would try to make a completely fresh gin branch and submit a new PR. There are pretty strict privacy rules for EEG data coming out of Europe so the best thing for files (I don't know the use-case super well for winwcp). Is there any patient information included in files? The file itself looks great though for merging into gin I just need to confirm that nothing private is in the pr. |
|
Ah no... I just wanted to merge the winwcp files. Not sure why the other ones were added... |
|
The other option is you can send the file here via zip and we can download it and then upload ourselves. The gin branching mechanism is hard to deal with so I'm not sure how you got the pegasus v2.2 since they aren't on the main branch, but my guess is the client accidentally synced you to the wrong branch. |
|
Yes the zip file sounds like a good option/short-cut. Still not sure how it managed to do that. Thanks for the help! |
|
Hi, @danielparthier I can add the file for you. Can you write some short info about the file (channels, size, purpose, etc) and about yourself (if you want) so we add it to the Readme for provenance. |
In the current version of WinWcpRawIO only limited information was read from the file. One missing part was the recording time (rec_datetime) which was now added to the header dict and block annotation.