Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.5.0 #154

Merged
merged 23 commits into from
Sep 9, 2021

Conversation

samuelgarcia
Copy link
Collaborator

No description provided.

@samuelgarcia
Copy link
Collaborator Author

Hi Jeffrey.
I would like to make a release but tests are still crashing on github.
I don't known what happen.
On my machine locally with PyQt5/python3.8 it works with same package version.
Theses remote crash are more complicated than standard python fails. I guess theses are C++/Qt5 stuff.
If you have time to pull this and test it on your local machine maybe you could help a bit.
Any idea ?

@samuelgarcia
Copy link
Collaborator Author

What about pytest-qt or pytest-xvfb ?

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 6, 2021

Hi Sam. Luckily I have time to look at this today! I'll get back to you.

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 6, 2021

What about pytest-qt or pytest-xvfb ?

Regarding pytest-xvfb, I tried that some months ago in a private branch from my unmerged PyQt6 PR (#147): jpgill86@7af3070. The tests did not pass at the time.

It has been so long that I don't really remember, but I think I was planning on waiting for #147 to be completed and merged before introducing pytest-xvfb on top of it. Of course, if it fixes the problem here, there is no reason I can see to wait.

I will continue to look into the failing tests, but I thought I'd mention my prior encounter with pytest-xvfb.

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 6, 2021

@samuelgarcia, I fixed the failing tests on the master branch in #155. It came down to a fix on one line of code, needed to work around a bug in Matplotlib.

You should rebase this branch onto master, or merge master into this branch, to clear up the failing tests.

@samuelgarcia
Copy link
Collaborator Author

Thank you so much!!!!
I will rebease I let you modify the changelog if you want and we could release this week.
Then maybe we can integrate the PyQt6.

@coveralls
Copy link

coveralls commented Sep 7, 2021

Coverage Status

Coverage increased (+0.01%) to 52.838% when pulling c942077 on samuelgarcia:prepare_release_1.4.1 into 7c82f8a on NeuralEnsemble:master.

@samuelgarcia
Copy link
Collaborator Author

@jpgill86 : I think this is readey to merge. Then you can tag for relase. Tell me if it is OK for you.

Thank you so much again for the very hard debug.

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 7, 2021

Hi @samuelgarcia,

I'm so glad it worked!

I have a few things I'd like to tweak. In particular, we can remove pytest-xvfb from requirements-tests.txt, but I'd like to modify the change log, the installation instructions, and maybe more.

Would you be willing to check the "Allow edits and access to secrets by maintainers" box in the right column of this PR? EDIT: Looks like I already had push privileges. Never mind!

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 7, 2021

Would it be a problem for you if we rename these classes?

  • FromSpikeinterfaceRecordingSource --> SpikeInterfaceRecordingSource, to be more consistent with other class names and to capitalize the i.
  • FromSpikeinterfaceSorintgSource --> SpikeInterfaceSortingSource, same reason, and to correct a spelling error.

You know SpikeInterface and I don't, so you'll know better whether the "From" is needed here. Compare to NeoAnalogSignalSource, etc.

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 7, 2021

Do we want to require Neo >= 0.10 now?

Edit: I didn't mean in requirements.txt. Just here and here.

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 7, 2021

Should this require SpikeInterface 0.90.1 instead of 0.90.0? From the SI release notes, it looks like __version__ wasn't exposed before 0.90.1.

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 7, 2021

An example for the docs of how to use the SpikeInterface sources would be nice, but if you want to get the release out as soon as possible, I understand.

@jpgill86 jpgill86 added this to the 1.4.1 milestone Sep 7, 2021
@jpgill86 jpgill86 changed the title prepare release 1.4.1 Prepare release 1.4.1 Sep 7, 2021
@samuelgarcia
Copy link
Collaborator Author

Hi Jeffrey,
I agree with all you comments. Thank you for the deep check.
I will make a spikeinterface example today.

About neo version in code and doc mayube we could keep (version - 0.2) so 0.8. What do you think it flexible to be compatible with some older version, no ?

@samuelgarcia samuelgarcia changed the title Prepare release 1.4.1 Prepare release 1.5.0 Sep 8, 2021
@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 9, 2021

@samuelgarcia, could you rebase/merge master now? We can then update the release notes, and then finally release. Almost there!

@samuelgarcia
Copy link
Collaborator Author

OK I merge with master stuff.

I let you update release notes ?

Thank you very much for all the time on this!!

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 9, 2021

Yes, I will take care of the notes. Is it alright if I go ahead with the release too?

@samuelgarcia
Copy link
Collaborator Author

Yes. You are the official boss now! Don't need to ask. :)

@jpgill86 jpgill86 force-pushed the prepare_release_1.4.1 branch from ed6e20a to c942077 Compare September 9, 2021 15:37
@jpgill86 jpgill86 merged commit 68e524a into NeuralEnsemble:master Sep 9, 2021
@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 9, 2021

@samuelgarcia, the release is done!

https://pypi.org/project/ephyviewer/

The new GitHub Actions for publishing to PyPI worked perfectly. I've updated my release instructions to include those new steps:

https://github.com/NeuralEnsemble/ephyviewer/wiki/Creating-a-release

@samuelgarcia
Copy link
Collaborator Author

Congratulation for your hard work. I was supposed to do it!!

Can the conda be more automed with a github actions ?

@jpgill86
Copy link
Collaborator

jpgill86 commented Sep 9, 2021

Can the conda be more automed with a github actions ?

Something we could do is this: #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants