-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 1.5.0 #154
Prepare release 1.5.0 #154
Conversation
Hi Jeffrey. |
What about pytest-qt or pytest-xvfb ? |
Hi Sam. Luckily I have time to look at this today! I'll get back to you. |
Regarding pytest-xvfb, I tried that some months ago in a private branch from my unmerged PyQt6 PR (#147): jpgill86@7af3070. The tests did not pass at the time. It has been so long that I don't really remember, but I think I was planning on waiting for #147 to be completed and merged before introducing pytest-xvfb on top of it. Of course, if it fixes the problem here, there is no reason I can see to wait. I will continue to look into the failing tests, but I thought I'd mention my prior encounter with pytest-xvfb. |
@samuelgarcia, I fixed the failing tests on the master branch in #155. It came down to a fix on one line of code, needed to work around a bug in Matplotlib. You should rebase this branch onto master, or merge master into this branch, to clear up the failing tests. |
Thank you so much!!!! |
@jpgill86 : I think this is readey to merge. Then you can tag for relase. Tell me if it is OK for you. Thank you so much again for the very hard debug. |
Hi @samuelgarcia, I'm so glad it worked! I have a few things I'd like to tweak. In particular, we can remove Would you be willing to check the "Allow edits and access to secrets by maintainers" box in the right column of this PR? EDIT: Looks like I already had push privileges. Never mind! |
Would it be a problem for you if we rename these classes?
You know SpikeInterface and I don't, so you'll know better whether the "From" is needed here. Compare to |
Should this require SpikeInterface 0.90.1 instead of 0.90.0? From the SI release notes, it looks like |
An example for the docs of how to use the SpikeInterface sources would be nice, but if you want to get the release out as soon as possible, I understand. |
Hi Jeffrey, About neo version in code and doc mayube we could keep (version - 0.2) so 0.8. What do you think it flexible to be compatible with some older version, no ? |
FromSpikeinterfaceSorintgSource --> SpikeInterfaceSortingSource
@samuelgarcia, could you rebase/merge master now? We can then update the release notes, and then finally release. Almost there! |
…into prepare_release_1.4.1
OK I merge with master stuff. I let you update release notes ? Thank you very much for all the time on this!! |
Yes, I will take care of the notes. Is it alright if I go ahead with the release too? |
Yes. You are the official boss now! Don't need to ask. :) |
ed6e20a
to
c942077
Compare
@samuelgarcia, the release is done! https://pypi.org/project/ephyviewer/ The new GitHub Actions for publishing to PyPI worked perfectly. I've updated my release instructions to include those new steps: https://github.com/NeuralEnsemble/ephyviewer/wiki/Creating-a-release |
Congratulation for your hard work. I was supposed to do it!! Can the conda be more automed with a github actions ? |
Something we could do is this: #163 |
No description provided.