Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed music app name to SoundClips #252

Merged
merged 13 commits into from
Aug 22, 2024
Merged

Changed music app name to SoundClips #252

merged 13 commits into from
Aug 22, 2024

Conversation

ebiwonjumit
Copy link
Contributor

No description provided.

@ebiwonjumit ebiwonjumit requested a review from dragazo August 7, 2024 17:47
@dragazo
Copy link
Contributor

dragazo commented Aug 8, 2024

Looks like there are still some references to music-app and/or MusicApp. But unrelated, I think the service name BeatBlox might be confusing with the extension BeatBlox. If it were me, I'd do something like SoundClips, but idk if Akos/Will were recommending otherwise.

@ebiwonjumit ebiwonjumit changed the title Changed music app name to BeatBlox Changed music app name to SoundClips Aug 21, 2024
@dragazo
Copy link
Contributor

dragazo commented Aug 21, 2024

Two of the interface tests are still failing (see details above), but otherwise looks good.

@dragazo dragazo merged commit cb11e29 into main Aug 22, 2024
2 of 3 checks passed
@dragazo dragazo deleted the music-app-name-change branch August 22, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants