Updated Music App Ordering and Sounds

[ebiwonjumit]

I updated the ordering of the RPC fields and extended the sound library.

[brollb]

What is a drum pack?

[ebiwonjumit]

The drumpacks are the folders/library containing each set of sounds. Its how the company we are using sounds from organized all their sounds. They would release them in drum packs(E.g. US x UK). I figured keeping them in this format would help us know which sounds kind of go together.
https://www.drumsampleshop.com/collections/drum-samples/products/usxuk-pack

[brollb]

What is a "one-shot type"? A single drum beat?

[ebiwonjumit]

A one-shot means the sound is a single drum hit. So imagine we record a drummer hitting the snare one time. Thats what a one-shot is. I chose to categorize them this way to distinguish from a drum loop which would be more than just a single hit.

[dragazo]

Minor thing: I just noticed that the RPCs in this service use PascalCase for inputs, but we have a convention of cammelCase. That should be an easy switch though.

[dragazo]

Looks good. I can go ahead and merge it if you're ready.

I'll also just note that the change in RPC inputs would ordinarily not be allowed for a released service like this one (as this breaks all existing projects that used it). But this service is technically marked as @alpha and is only on editor because (iirc) Brian still has it editor set to use dev services. In future changes, it might be good if there's a more general way to search that's not so specific to individual datasets.

[brollb]

@ebiwonjumit - Can you check out the failing test? I am seeing this error in the github action:

  997 passing (12s)
  4 pending
  1 failing

  1) music-app
       should return audio buffer in response:
     AssertionError [ERR_ASSERTION]: null == 200
      at Context.<anonymous> (test/procedures/music-app.spec.js:29:12)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@dragazo is correct that the dev services are currently available on editor.netsblox.org. I would like to change that since I see services like the MATLAB service available (which we don't want to expose). However, I will need to make sure this service is publicly available for the demos...

[ebiwonjumit]

@dragazo @brollb Let me double check the error and then please go ahead and merge