fix send img crash (#230)

* fix send img crash * Fix code formatting --------- Co-authored-by: Format Bot <[email protected]>
NetsBlox · Apr 27, 2024 · 00044ff · 00044ff
1 parent 73d97c7
commit 00044ff
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/src/procedures/utils/api-consumer.js b/src/procedures/utils/api-consumer.js
@@ -146,7 +146,7 @@ class ApiConsumer extends NBService {
     let requestImage = () => {
       logger.trace("requesting image from", fullUrl);
       const deferred = defer();
-      const imgResponse = request.get(fullUrl);
+      const imgResponse = request.get(fullUrl, (err) => deferred.reject(err));
       delete imgResponse.headers["cache-control"];
       imgResponse.on("response", (res) => {
         try {
@@ -240,11 +240,16 @@ class ApiConsumer extends NBService {
   }
 
   // sends an image to the user
-  _sendImage(queryOptions) {
-    return this._requestImage(queryOptions)
-      .then((imageBuffer) => {
-        this._sendImageBuffer(imageBuffer);
-      });
+  async _sendImage(queryOptions) {
+    let img;
+    try {
+      img = await this._requestImage(queryOptions);
+    } catch (e) {
+      this._logger.trace("failed to load image", e);
+      return "failed to load image";
+    }
+
+    return this._sendImageBuffer(img);
   }
 
   // helper test the response