Add required flag #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since NethermindEth/juno#2249, it's now required to either pass the --eth-node flag or --disable-l1-verification
wojciechos
approved these changes
Nov 6, 2024
wojciechos
reviewed
Nov 6, 2024
| @@ -15,6 +15,7 @@ def run(plan, name, participant): | |||
| "--http-host", "0.0.0.0", | |||
| "--log-level", "debug", | |||
| "--db-path", "/var/lib/juno", | |||
| "--disable-l1-verification" | |||
There was a problem hiding this comment.
The issue is that, in the current pipeline, tests are run by default on the latest released juno version (nethermind/juno:latest), which doesn’t support this flag yet so pipeline gonna fail.
There was a problem hiding this comment.
oh, we are getting this from Docker hub instead of artifactory, right?
There was a problem hiding this comment.
Yep, same applies to Pathfinder (eqlabs/pathfinder:latest-p2p) and Madara (ghcr.io/madara-alliance/madara:latest).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since NethermindEth/juno#2249,
it's now required to either pass the --eth-node flag or
--disable-l1-verification