Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenesisTimeoutMs to BlocksConfig #7457

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Sep 18, 2024

Feature requested in #7361

Changes

  • Makes genesis timeout configurable, 40s by default.
  • Add hint to the error about when this can be useful.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Remarks

  • GenesisHash is still in InitConfig and now it is inconsistent
  • Wondered if it should be Ms or S, but we always have Ms in other places so made it that.

@LukaszRozmej LukaszRozmej merged commit ec4a833 into master Sep 18, 2024
66 checks passed
@LukaszRozmej LukaszRozmej deleted the feature/genesis-timeout-config branch September 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants