Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 'TxValidator' further #7402

Merged

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Sep 8, 2024

Goes deeper into #7386

Changes

  • Adds syntactic sugar for validation
  • Adds RegisterTxType as standard way of registering transactions
  • Move TxValidator to array instead of dictionary
  • Allow register TxValidator from plugins
  • Remove tests that had 4844 but not 1559,
  • Made 1559 enabled when 4844 is enabled.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Move TxValidator to array instead of dictinary
Allow register TxValidator from plugins
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some small code style comments.

@LukaszRozmej LukaszRozmej merged commit ec0d5a2 into refactor/tx-validator Sep 9, 2024
58 of 60 checks passed
@LukaszRozmej LukaszRozmej deleted the refactor/tx-validator-more-refactor branch September 9, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants