-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor 'TxValidator' further #7402
Merged
LukaszRozmej
merged 10 commits into
refactor/tx-validator
from
refactor/tx-validator-more-refactor
Sep 9, 2024
Merged
Refactor 'TxValidator' further #7402
LukaszRozmej
merged 10 commits into
refactor/tx-validator
from
refactor/tx-validator-more-refactor
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move TxValidator to array instead of dictinary Allow register TxValidator from plugins
LukaszRozmej
commented
Sep 8, 2024
Made 1559 enabled when 4844 is enabled.
LukaszRozmej
requested review from
jmederosalvarado,
ak88 and
smartprogrammer93
September 8, 2024 11:56
12 tasks
jmederosalvarado
requested changes
Sep 9, 2024
emlautarom1
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only some small code style comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes deeper into #7386
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?