Refactor TxValidator

src/Nethermind/Nethermind.Api/IApiWithBlockchain.cs

@@ -74,7 +74,7 @@ public interface IApiWithBlockchain : IApiWithStores, IBlockchainBridgeFactory
         IHealthHintService? HealthHintService { get; set; }
         IRpcCapabilitiesProvider? RpcCapabilitiesProvider { get; set; }
         ITransactionComparerProvider? TransactionComparerProvider { get; set; }
-        ITxValidator? TxValidator { get; set; }
+        TxValidator? TxValidator { get; set; }
 
         /// <summary>
         /// Manager of block finalization

src/Nethermind/Nethermind.Api/NethermindApi.cs

@@ -208,7 +208,7 @@ public ISealEngine SealEngine
         public ITxPoolInfoProvider? TxPoolInfoProvider { get; set; }
         public IHealthHintService? HealthHintService { get; set; }
         public IRpcCapabilitiesProvider? RpcCapabilitiesProvider { get; set; }
-        public ITxValidator? TxValidator { get; set; }
+        public TxValidator? TxValidator { get; set; }
         public IBlockFinalizationManager? FinalizationManager { get; set; }
         public IGasLimitCalculator? GasLimitCalculator { get; set; }
 

src/Nethermind/Nethermind.Blockchain.Test/Validators/TxValidatorTests.cs

@@ -531,6 +531,50 @@ public void IsWellFormed_BlobTxHasProofOverTheSizeLimit_ReturnFalse()
         Assert.That(txValidator.IsWellFormed(tx, Cancun.Instance, out error), Is.False);
     }
 
+    /// <remarks>
+    /// According to https://github.com/ethereum/EIPs/blob/e2c094cd0f50303eddcfb87f36899e00545dcaaf/EIPS/eip-4844.md?plain=1#L11
+    /// EIP 4844 implies 1559, thus the <c>ReleaseSpec</c> we're constructing here should not be possible.
+    /// </remarks>
+    [Test]
+    public void BlobTransactions_are_valid_with_eip4844_no_eip1559()
+    {
+        Transaction tx = Build.A.Transaction
+            .WithType(TxType.Blob)
+            .WithTimestamp(ulong.MaxValue)
+            .WithTo(TestItem.AddressA)
+            .WithMaxFeePerGas(1)
+            .WithMaxFeePerBlobGas(1)
+            .WithBlobVersionedHashes(1)
+            .WithChainId(TestBlockchainIds.ChainId)
+            .SignedAndResolved().TestObject;
+
+        TxValidator txValidator = new(TestBlockchainIds.ChainId);
+        IReleaseSpec releaseSpec = new ReleaseSpec() { IsEip4844Enabled = true, IsEip1559Enabled = false };
+
+        txValidator.IsWellFormed(tx, releaseSpec).Should().BeTrue();
+    }
+
+    /// Same as <see cref="BlobTransactions_are_valid_with_eip4844_no_eip1559"/>
+    [Test]
+    public void BlobTransactions_bad_gas_fields_is_valid_when_no_eip1559()
+    {
+        Transaction tx = Build.A.Transaction
+            .WithType(TxType.Blob)
+            .WithTimestamp(ulong.MaxValue)
+            .WithTo(TestItem.AddressA)
+            .WithMaxFeePerGas(1)
+            .WithMaxPriorityFeePerGas(2)
+            .WithMaxFeePerBlobGas(1)
+            .WithBlobVersionedHashes(1)
+            .WithChainId(TestBlockchainIds.ChainId)
+            .SignedAndResolved().TestObject;
+
+        TxValidator txValidator = new(TestBlockchainIds.ChainId);
+        IReleaseSpec releaseSpec = new ReleaseSpec() { IsEip4844Enabled = true, IsEip1559Enabled = false };
+
+        txValidator.IsWellFormed(tx, releaseSpec).Should().BeTrue();
+    }
+
     private static byte[] MakeArray(int count, params byte[] elements) =>
         elements.Take(Math.Min(count, elements.Length))
             .Concat(new byte[Math.Max(0, count - elements.Length)])