-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for state override parameter in some RPC methods #7362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verride # Conflicts: # src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs
alexb5dh
commented
Aug 26, 2024
alexb5dh
commented
Aug 26, 2024
alexb5dh
force-pushed
the
feature/rpc-state-override
branch
from
September 1, 2024 00:55
6cb949c
to
00aae73
Compare
alexb5dh
force-pushed
the
feature/rpc-state-override
branch
from
September 3, 2024 10:56
00aae73
to
363fdc9
Compare
…verride # Conflicts: # src/Nethermind/Nethermind.Trie/Pruning/TrieStore.cs
LukaszRozmej
approved these changes
Oct 30, 2024
emlautarom1
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthRpcModuleTests.EstimateGas.cs
Outdated
Show resolved
Hide resolved
OlegJakushkin
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! solves some issues on StateRoot in eth_simulate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4021, resolves #6120, resolves #7306.
Changes
eth_call
,eth_estimategas
trace_call
debug_traceCall
trace_call
,trace_callMany
,trace_rawTransaction
debug_traceCall
TraceRpcModuleTests
andDebugRpcModuleTests
- to make it more consistent with regular setup.Fixes double-serialization of some of the parameters in the RPC tests.What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes