Split Status into FinalityStatus and ExecutionStatus #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 73.09% 72.79% -0.30%
==========================================
Files 59 59
Lines 6255 6279 +24
==========================================
- Hits 4572 4571 -1
- Misses 1300 1319 +19
- Partials 383 389 +6
☔ View full report in Codecov by Sentry. |
|
Resolves #881 |
Merged
joshklop
force-pushed
the
joshklop/rpc-0.4.0
branch
from
10f5576
to
9ebebfb
Compare
joshklop
changed the title
joshklop
force-pushed
the
joshklop/rpc-0.4.0
branch
from
9ebebfb
to
8c925cd
Compare
joshklop
requested review from
a team and
IronGauntlets
and removed request for
a team
IronGauntlets
force-pushed
the
joshklop/rpc-0.4.0
branch
from
8c925cd
to
3261059
Compare
omerfirmak
reviewed
Jul 18, 2023
omerfirmak
reviewed
Jul 18, 2023
joshklop
force-pushed
the
joshklop/rpc-0.4.0
branch
from
3261059
to
fb0f3ba
Compare
joshklop
force-pushed
the
joshklop/rpc-0.4.0
branch
3 times, most recently
from
7eb4a25
to
3c3ee0f
Compare
Makes room for separate transaction statuses later
We need the `execution_status` and `finality_status` fields on receipts.
joshklop
force-pushed
the
joshklop/rpc-0.4.0
branch
from
3c3ee0f
to
3047618
Compare
- Add ExecutionStatus to receipt type - Replace Status with FinalityStatus on receipt type - Return a struct from juno_getTransactionStatus containing the execution and finality statuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.