-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs discoverd by e2e tests #2407
Open
AnkushinDaniil
wants to merge
8
commits into
main
Choose a base branch
from
daniil/fix-e2e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+714
−307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkushinDaniil
force-pushed
the
daniil/fix-e2e
branch
from
January 29, 2025 07:36
5d919e9
to
65aa0f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
==========================================
- Coverage 74.41% 74.22% -0.19%
==========================================
Files 113 113
Lines 13016 13088 +72
==========================================
+ Hits 9686 9715 +29
- Misses 2592 2632 +40
- Partials 738 741 +3 ☔ View full report in Codecov by Sentry. |
AnkushinDaniil
force-pushed
the
daniil/fix-e2e
branch
from
January 29, 2025 09:15
eac3b4b
to
09d860a
Compare
AnkushinDaniil
force-pushed
the
daniil/fix-e2e
branch
from
January 31, 2025 12:38
09d860a
to
94cf299
Compare
rodrigo-pino
added
RPC
JSON RPC API
blocked
Depends on another to be solved first
labels
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
This PR implements simple PRC version control. Basically it introduces a new
rpcVersion
field responsible for RPC version. It affects theMarshalJSON
method. The only exception isBlockHeader
, because if we implement this method for this structure, all structuresBlockWith*
containingBlockHeader
will use this method and we will see onlyBlockHeader
. In these cases we simply make theL2Gas
fieldnil
if necessary. In addition, in #2401 therpcVersion
field is used in some calculations in the fee estimation.Below are the key changes grouped by theme:
Removal of L2 Gas Fields:
L2Gas
field from theDataAvailability
struct incore/transaction.go
.L2Gas
field handling inadaptExecutionResources
functions inadapters/core2p2p/receipt.go
andadapters/p2p2core/receipt.go
. [1] [2]RPC Method Versioning:
V0_7
andV0_8
inrpc/handlers.go
.rpc/block.go
andrpc/handlers.go
, such asBlockWithTxHashesV0_7
,BlockWithTxsV0_7
, andBlockWithReceiptsV0_7
. [1] [2] [3]Fee Estimation Adjustments:
FeeEstimateV0_7
struct and integrated versioning into theFeeEstimate
struct inrpc/estimate_fee.go
. [1] [2]EstimateFeeV0_7
andEstimateMessageFeeV0_7
methods to use the new versioning approach. [1] [2]Test Updates:
rpc/block_test.go
andrpc/estimate_fee_pkg_test.go
to accommodate the changes in fee estimation and RPC method versioning. [1] [2] [3]