Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more pebble database metrics collection #2187

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

weiihann
Copy link
Contributor

Adds the following metrics:

db_compaction_time - Total time spent in database compaction
db_compaction_read - Total bytes read during compaction
db_compaction_write - Total bytes written during compaction
db_write_delay_count - Total write delay counts due to database compaction
db_write_delay_time - Total time spent in write stalls
db_disk_size - Tracks the size of all of the levels of the database
db_disk_write - Measures the effective amount of data written to disk
db_mem_comp - Tracks the amount of memory allocated for compaction
db_level0_comp - Tracks the number of level-zero compactions
db_nonlevel0_comp - Tracks the number of non level-zero compactions
db_seek_comp - Tracks the number of table compactions caused by read operations
db_manual_mem_alloc - Tracks the amount of non-managed memory currently allocated

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 87.43719% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.79%. Comparing base (73be13e) to head (a915ecf).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
db/pebble/db.go 87.56% 22 Missing and 1 partial ⚠️
db/remote/db.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   78.56%   78.79%   +0.22%     
==========================================
  Files         102      102              
  Lines        9205     9383     +178     
==========================================
+ Hits         7232     7393     +161     
- Misses       1342     1361      +19     
+ Partials      631      629       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kirugan kirugan force-pushed the weiihann/db-enhance branch from 32f672e to 156f0e1 Compare October 3, 2024 11:54
@rianhughes rianhughes self-requested a review October 7, 2024 08:20
db/pebble/db.go Outdated Show resolved Hide resolved
@weiihann weiihann force-pushed the weiihann/db-enhance branch from 156f0e1 to c2b2a8d Compare October 7, 2024 10:43
db/pebble/db.go Outdated Show resolved Hide resolved

// collectMetrics periodically retrieves internal pebble counters and reports them to
// the metrics subsystem.
func (d *DB) StartMetricsCollection(ctx context.Context, refresh time.Duration) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be worth adding a test for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to. It's not easy to add tests for them as we have to create an actual pebbleDB instead of relying on in-memory. If it goes wrong, it shouldn't affect the main application, and most likely we will detect the weird behaviors when we see it on Grafana.

Comment on lines +315 to +316
nWrite += int64(levelMetrics.BytesCompacted)
nWrite += int64(levelMetrics.BytesFlushed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need other fields like BytesMoved or BytesIngested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You raised a good point :)

BytesMoved represents the bytes moved during compactions. Since we're already counting BytesCompacted, we don't need to include BytesMoved to avoid double-counting.

BytesIngested represents bytes added through ingestion (e.g., bulk loading). We should include this in our nWrite calculation as it represents additional data written to the database.

@weiihann weiihann force-pushed the weiihann/db-enhance branch from c2b2a8d to a915ecf Compare October 7, 2024 15:06
Copy link
Contributor

This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants