Add log encoding option for JSON logging. #2166
Conversation
This option allows selection of either CONSOLE (the default, and the current behaviour) or JSON for log output, allowing for easier parsing of output for structued log backends.
|
this is a great addition. hope this is merged in soon. curious why you chose to call it encoding, instead of format |
Encoding is the term used internally in the logging. Also, format can be the format for individual fields (e.g. timestamp format) rather than the general encoding of the log entry. |
Signed-off-by: Jim McDonald <[email protected]>
|
@pnowosie should be fixed, but workflows need running to confirm. |
Oops - right ;) |
| ) | ||
|
|
||
| const ( | ||
| CONSOLE LogEncoding = iota |
There was a problem hiding this comment.
Can we rename it to Console please? according to standard go naming convention for const
There was a problem hiding this comment.
That isn't part of this PR, CONSOLE and some other constants in utils/log.go weren't created with this commit. I suggest a separate issue/PR if you want to address that.
This option allows selection of either CONSOLE (the default, and the current behaviour) or JSON for log output, allowing for easier parsing of output for structued log backends.