Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it clear that MaxFee field is not used anymore for V3 tx + improve comments for Transactions #2130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TAdev0
Copy link

@TAdev0 TAdev0 commented Sep 10, 2024

Closes #2129

also reorganize fields to make it clearer in general

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.31%. Comparing base (71c7ca2) to head (299f1e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   78.33%   78.31%   -0.03%     
==========================================
  Files         100      100              
  Lines        9221     9221              
==========================================
- Hits         7223     7221       -2     
  Misses       1357     1357              
- Partials      641      643       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TAdev0 TAdev0 changed the title make it clear that MaxFee field is not used anymore for V3 tx make it clear that MaxFee field is not used anymore for V3 tx + improve comments Sep 10, 2024
@TAdev0 TAdev0 changed the title make it clear that MaxFee field is not used anymore for V3 tx + improve comments make it clear that MaxFee field is not used anymore for V3 tx + improve comments for Transactions Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaxFee field for all types of transactions should be removed for V3
2 participants