Update preconf registry 2 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailUshakoff
approved these changes
Aug 22, 2024
| revert InvalidValidatorSignature(); | ||
| } | ||
|
|
||
| // Revert if the signature has expired | ||
| if (block.timestamp > addValidatorParams[i].signatureExpiry) { |
There was a problem hiding this comment.
Maybe we should check it before verifying the signature?
| emit ValidatorRemoved(msg.sender, validatorPubKeyHashes[i]); | ||
|
|
||
| // Revert if the signature has expired | ||
| if (block.timestamp > removeValidatorParams[i].signatureExpiry) { |
There was a problem hiding this comment.
Maybe we should check it before verifying the signature?
There was a problem hiding this comment.
The transaction libraries stop the transaction on estimation stage itself, so in practise, the order of reverts usually does not matter in the contracts.
| pragma solidity 0.8.25; | ||
|
|
||
| library PreconfConstants { | ||
| uint256 internal constant TWO_EPOCHS = 768; |
There was a problem hiding this comment.
Suggested change
| uint256 internal constant TWO_EPOCHS = 768; | |
| uint256 internal constant TWO_EPOCHS = 768; // 2 * 32 slots * 12 sec |
Update lookahead and connect it to new registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexToPreconfermapping to remove the need to index preconfers on the node.validatorsmap and can be pulled by node (to build the lookahead) usinggetValidatorview.addValidatorsandremoveValidatorsso they can be called by anyone with the correct signatures and not necessarily the preconfer's address.