Send new block proposal by raw tx #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskrzypkows
commented
Jul 4, 2024
swapnilraj
reviewed
Jul 4, 2024
Node/src/ethereum_l1/mod.rs
Outdated
| let signer = PrivateKeySigner::from_str(private_key)?; | ||
| let wallet = EthereumWallet::from(signer); | ||
|
|
||
| Ok(Self { | ||
| rpc_url: rpc_url.parse()?, | ||
| wallet, | ||
| new_block_proposal_contract_address: new_block_proposal_contract_address.parse()?, |
There was a problem hiding this comment.
nit: let's call it the taiko_preconfirming_address
swapnilraj
reviewed
Jul 4, 2024
swapnilraj
reviewed
Jul 4, 2024
Node/src/taiko/l2_tx_lists.rs
Outdated
| #[derive(Serialize, Deserialize, Debug)] | ||
| #[serde(rename_all = "PascalCase")] | ||
| pub struct RPCReplyL2TxLists { | ||
| pub tx_lists: Value, |
There was a problem hiding this comment.
my preference would be to put the correct type instead of Value but happy to skip if its too much for devnet
let's put a TODO here otherwise
There was a problem hiding this comment.
Agree, but this is in the json::Value form because I pass directly the same json to the driver to advance the head, so after parsing it to the type I would need to encode it for driver.
swapnilraj
reviewed
Jul 4, 2024
Node/src/utils/config.rs
Outdated
| impl Config { | ||
| pub fn read_env_variables() -> Self { | ||
| const ETHEREUM_PRIVATE_KEY: &str = "ETHEREUM_PRIVATE_KEY"; | ||
| const NEW_BLOCK_PROPOSAL_CONTRACT_ADDRESS: &str = "NEW_BLOCK_PROPOSAL_CONTRACT_ADDRESS"; |
There was a problem hiding this comment.
TAIKO_PRECONFIRMING_ADDRESS
swapnilraj
approved these changes
Jul 4, 2024
smartprogrammer93
approved these changes
Jul 4, 2024
mskrzypkows
added a commit
that referenced
this pull request
Jul 7, 2024
* RPC client for fetching tx lists (#23) * RPC client for fetching tx lists RPC server for tests * Improve async processing and error handling * More assert to the gen l2 tx test --------- Co-authored-by: Denis Kolodin <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> * submit new l2 blocks using RPC (#28) * submit_new_l2_blocks implemented * fixed tests * Fix loops in Node/src/node/mod.rs to be consistent (#38) every 4 seconds and not blocked by channel processing Co-authored-by: Ahmad Bitar <[email protected]> * Two RCP addresses for the Node fixed some JSON RPC compatibility with taiko-clients * unused import * small fixes --------- Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> * Unit test for deployment and call of Ethereum contract (#39) * Unit test for deployment and call of Ethereum contract * foundry for github actions * propose_new_block call with empty parameters * Default params for the newBlockProposal * rest parameter passed to the propose_new_block * Send new block proposal by raw tx (#47) * build Eip1559 transaction * Handling additional arguments passed by JSON RPC from proposer * Forwarding of encoded tx to the mev boost module * Configuration parameters take form the ENV * sending new block proposal using builder.send * renamed according to the review --------- Co-authored-by: Denis Kolodin <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.