Fix for the write error #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlautarom1
approved these changes
Jun 21, 2023
|
This is hidden as a property. Let me add one test for this then! |
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on fixing the overflow error 😭 . The data were written at the wrong page as the offset silently overflown in the
MemoryMappedPageManager. Now, with a new property ofDbAddressthat does the calculation in one place this should not be the case.Additionally, a few
[DebuggerStepThrough]are added to help future battles.One more thing is that
AwaitWritesare properly awaited at the end of the writing loop!